[SOLVED] tis-deepl problem

[Mikael S]

Good morning,

We are having a problem with the tis-deepl package. The installation completes successfully, but the application crashes

Code: Select all

Application: DeepL.exe
CoreCLR Version: 10.0.1226.42308
.NET Version: 10.0.12
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.FileNotFoundException: Could not load file or assembly 'Sentry, Version=6.8.0.0, Culture=neutral, PublicKeyToken=fba2ec45388e2af0'. Le fichier spécifié est introuvable.
File name: 'Sentry, Version=6.8.0.0, Culture=neutral, PublicKeyToken=fba2ec45388e2af0'
   at Sentry.Generated.BuildPropertyInitializer.Initialize()
   at Sentry.Generated.BuildPropertyInitializer.Initialize()
   at .cctor()

Code: Select all

Nom de l'application défaillante : DeepL.exe, version : 26.8.2.20990, horodatage : 0x693c0000
Nom du module défaillant : KERNELBASE.dll, version : 10.0.26100.9444, horodatage : 0x28606b21
Exception code: 0xe0434352
Fault offset: 0x00000000000c41ca
Identifiant du processus défaillant : 0x360C
Heure de début de l'application défaillante : 0x1DD45E0D9E34427
Chemin de l'application défaillante : C:\Program Files\DeepL\DeepL.exe
Chemin du module défaillant : C:\WINDOWS\System32\KERNELBASE.dll
ID du rapport : d50b5806-ea48-4f29-a86e-e6ffabef1ec2
Nom complet du package défaillant : 
Package défaillant – ID d'application relatif : 

The application works correctly with the official installer.
Are you experiencing the same problem?



Sincerely,

[kcherel]

Good morning,

I've just corrected the code; could you try modifying setup.py with this code?

Code: Select all

# -*- coding: utf-8 -*-
from setuphelpers import *
from setupdevhelpers import unzip_with_7zip

"""
    Usage of the DeepLSetup.exe seems to crash when there is already 0install installed.
    It tries to override the 0install directory in Program Files (C:\Program Files\Zero Install\)

    We are now doing a portable install of DeepL with the sources downloaded from 0install executable.
    This allow to avoid a lot of complication due to the usage of 0install and wrong usage of 0install by Deepl.
"""
app_name = "DeepL"
app_dir = makepath(programfiles, app_name)
app_path = makepath(app_dir, f"{app_name}.exe")
icon_path = app_path
audit_version = True

def install():
    # Uninstalling older package version (if deepl in registry, it is old package version)
    for to_uninstall in installed_softwares(name="DeepL"):
        print("Removing: %s (%s)" % (to_uninstall["name"], to_uninstall["version"]))
        killalltasks(ensure_list(control.impacted_process))
        run(uninstall_cmd(to_uninstall["key"]))
        wait_uninstallkey_absent(to_uninstall["key"])

    # Declaring local variables
    archive_name = glob.glob(f"{app_name}.zip")[0]

    # Installing software
    killalltasks(ensure_list(control.impacted_process))
    if isdir(app_dir) and force:
        remove_tree(app_dir)

    bin_name = glob.glob("DeepLSetup.exe")[0]
    run(bin_name + r" --machine --verysilent")

    # Creating custom shortcuts
    create_desktop_shortcut(bin_name)
    create_programs_menu_shortcut(bin_name)


def audit():
    # Auditing software
    audit_status = "OK"
    installed_version = get_installed_version(app_path)
    if Version(installed_version) < Version(control.get_software_version()) and audit_version:
        print("%s is installed in version (%s) instead of (%s)" % (app_name, installed_version, control.get_software_version()))
        audit_status = "WARNING"
    elif isdir(app_dir) and not dir_is_empty(app_dir):
        print("%s (%s) is installed" % (app_name, installed_version))
        audit_status = "OK"
    else:
        print("%s is not installed" % app_name)
        audit_status = "ERROR"
    return audit_status


def uninstall():
    # Uninstalling software
    killalltasks(ensure_list(control.impacted_process))
    if isdir(app_dir):
        remove_tree(app_dir)

    # Removing shortcuts
    remove_desktop_shortcut(app_name)
    remove_programs_menu_shortcut(app_name)

[Mikael S]

Hello,

with this setup, it works correctly.



Regards,

[Mikael S]

except for the audit, which is no longer good

[kcherel]

Yes, indeed, I just noticed. You can try again with this code:

Code: Select all

# -*- coding: utf-8 -*-
from setuphelpers import *
from setupdevhelpers import unzip_with_7zip

"""
    Usage of the DeepLSetup.exe seems to crash when there is already 0install installed.
    It tries to override the 0install directory in Program Files (C:\Program Files\Zero Install\)

    We are now doing a portable install of DeepL with the sources downloaded from 0install executable.
    This allow to avoid a lot of complication due to the usage of 0install and wrong usage of 0install by Deepl.
"""
app_name = "DeepL"
app_dir = makepath(programfiles, app_name)
app_path = makepath(app_dir, f"{app_name}.exe")
icon_path = app_path
audit_version = True

def install():
    # Uninstalling older package version (if deepl in registry, it is old package version)
    for to_uninstall in installed_softwares(name="DeepL"):
        print("Removing: %s (%s)" % (to_uninstall["name"], to_uninstall["version"]))
        killalltasks(ensure_list(control.impacted_process))
        run(uninstall_cmd(to_uninstall["key"]))
        wait_uninstallkey_absent(to_uninstall["key"])

    # Declaring local variables
    archive_name = glob.glob(f"{app_name}.zip")[0]

    # Installing software
    killalltasks(ensure_list(control.impacted_process))
    if isdir(app_dir) and force:
        remove_tree(app_dir)

    bin_name = glob.glob("DeepLSetup.exe")[0]
    run(bin_name + r" --machine --verysilent")

    # Creating custom shortcuts
    create_desktop_shortcut(bin_name)
    create_programs_menu_shortcut(bin_name)

def audit():
    print("Auditing: %s" % control.package)

    if installed_softwares(name=app_name):
        print("%s is installed" % app_name)
        return "OK"

    print("%s is not installed" % app_name)
    return "ERROR"

def uninstall():
    # Uninstalling software
    killalltasks(ensure_list(control.impacted_process))
    if isdir(app_dir):
        remove_tree(app_dir)

    for to_uninstall in installed_softwares(name="DeepL"):
        print("Removing: %s (%s)" % (to_uninstall["name"], to_uninstall["version"]))
        killalltasks(ensure_list(control.impacted_process))
        run(to_uninstall["uninstall_string"])
        wait_uninstallkey_absent(to_uninstall["key"])

    # Removing shortcuts
    remove_desktop_shortcut(app_name)
    remove_programs_menu_shortcut(app_name)

Sorry for the mistake, it will be available in production on the store in 5 days.

Sincerely,
Kevin.