Page 1 of 2

Flash installation error

Published: January 18, 2017 - 5:31 PM
by Omahaddict
Hello everyone,
On some computers I'm getting an error with the Flash package:

Installing flash for firefox
EWaptSetupException: Fatal error: MSI install_flash_player_24_plugin.msi has been installed but the uninstall key {1D95F7C4-A547-4FC9-91A4-A35B19F597C0} cannot be found.

I'm using Firefox v49.0.1-65.

I'm having a little trouble understanding what this means. Could it be due to a registry cleanup during previous uninstallations?
I also had this error with the previous version of the package. The package status changes to "Need Upgrade" and the computer status is therefore "Error".

Thank you for your help.

Re: Flash installation error

Published: January 18, 2017 - 5:37 PM
by htouvet
Perhaps a version of Flash incompatible with your OS?

Try installing it manually on one of the machines to see if a specific error appears.

Re: Flash installation error

Published: January 19, 2017 - 10:11 AM
by Omahaddict
When I unzip the package and launch Flash Player, it tells me that a newer version is already installed... :?
Could mixing packages (I remember using a package from Simon for Flash because it wasn't yet on the TIS repository) cause problems in general, and more specifically in this case?
I'm running Windows 7, with a homogeneous network, so I think the incompatibility would manifest itself on all my machines. On the same set of machines, some installations went smoothly, others didn't.

Re: Flash installation error

Published: January 20, 2017 - 10:46 AM
by htouvet
The problem isn't specifically related to the flash package itself, but rather to how `msi_install_if_needed` works.

If the already installed version of the software is newer than the version you want to install, the `msi_install_if_needed` function doesn't restart the installation, which is fine.
However, what isn't correct is that the uninstallation key is still added to the `uninstall_key` list... so it's a bug... :) that needs fixing,

Hubert.

Re: Flash installation error

Published: January 23, 2017 - 09:45
by Omahaddict
Okay, thanks.
I have the same problem with Java, so I imagine it's the same thing.
Good luck and congratulations again on your software! ;)

Re: Flash installation error

Published: January 23, 2017 - 1:04 PM
by sfonteneau
I discussed it with Hubert this morning; the fact that the uninstallation key is still added to the uninstall_key list is logical, so it's not a bug.

Re: Flash installation error

Published: January 26, 2017 - 09:32
by Omahaddict
Okay, but then why does it tell me a key is already installed when there's no newer version installed?
I'm having the same problem with Java.
On some machines, the status shows an error, and the package updates but doesn't reinstall properly when I force a clean install.

Re: Flash installation error

Published: January 26, 2017 - 10:14 AM
by sfonteneau
The installation is not forced if the version is equal to or greater than the version installed on the machine [1]. The WAPT client will correctly see a package as needing an upgrade, but during installation, it will not restart the installation process.

Can you tell me the error for the package with an "error status"

[1] https://github.com/tranquilit/WAPT/blob ... s.py#L3536

Re: Flash installation error

Published: January 26, 2017 - 11:45 AM
by Omahaddict
Console message:
Installing flash for firefox
EWaptSetupException: Fatal error: MSI install_flash_player_24_plugin.msi has been installed but the uninstall key {1D95F7C4-A547-4FC9-91A4-A35B19F597C0} cannot be found.
Package still in need-upgrade status. If I force it, it reinstalls the package but always ends with this error.

Re: Flash installation error

Published: January 26, 2017 - 1:18 PM
by sfonteneau
Omahaddict wrote:Console message:
Installing flash for firefox
EWaptSetupException: Fatal error: MSI install_flash_player_24_plugin.msi has been installed but the uninstall key {1D95F7C4-A547-4FC9-91A4-A35B19F597C0} cannot be found.
Package still in need-upgrade status. If I force it, it reinstalls the package but always ends with this error.
During installation, wapt cannot find the uninstallkey {1D95F7C4-A547-4FC9-91A4-A35B19F597C0}, which means that it needs to restart the installation of the flash player npapi (plugin)

The installation proceeds smoothly without returning an error code, but as a security measure, after installation, Wapt checks if the uninstallkey {1D95F7C4-A547-4FC9-91A4-A35B19F597C0} is present. If it's not present, this doesn't make sense since we just launched the installation, so Wapt intentionally flags the package as an error to retry the installation later!

To diagnose where the problem is coming from, you can manually launch the installation of the MSI Flash Player plugin to see a potential error message and understand why the installation is failing.