[SOLVED] Docker packet issue

[yoann.montouchet]

Good morning,
We use the package packed by Tranquil-IT for Docker Desktop, we have noticed the absence of updates to this package since version 4.40, for Windows.
For macOS, more recent versions have been packaged by luti without any problems (and install well, no problems for us).
We tried the update package, which runs fine, but the resulting packages do not install.
We get an error at the end of the installation:

Code: Select all

Fatal error : Setup Docker Desktop Installer.exe has been executed and key Docker Desktop has been found in the registry, but version in registry does not match requirements of min_version=4.42.0

The explanation seems to stem from the fact that when executing the "update package", it assumes the binary is already present and should not be replaced:

Code: Select all

URL used is: https://docs.docker.com/desktop/release-notes/
Latest Docker Desktop version is: 4.42.0
Download URL is: https://desktop.docker.com/win/main/amd64/195023/Docker%20Desktop%20Installer.exe
Binary is present: Docker Desktop Installer.exe
Software version updated (from: 4.40.0 to: 4.42.0)

In practice, it systematically installs version 4.40 of Docker Desktop, the version we had packaged before launching the "update package".

In the code, I see that it relies solely on the name to determine whether the file already exists or not:

Code: Select all

    if not isfile(latest_bin):
        print("Downloading: %s" % latest_bin)
        wget(download_url, latest_bin, proxies=proxies)
    else:
        print("Binary is present: %s" % latest_bin)

I think that's what's causing the problem. It's not downloading the new version even though the link points to a new version (the version in the downloaded executable is indeed 4.42), because a file with the same name as the one it wants to download is already present.
Is that why Luti isn't packaging new versions?

For my part, I propose removing this block which is not useful for Docker Desktop, since all installation binaries always have the same name.
I'm going to do this locally to confirm that it installs correctly, and will update this thread if it does.

[yoann.montouchet]

So I replaced the block:

Code: Select all

    if not isfile(latest_bin):
        print("Downloading: %s" % latest_bin)
        wget(download_url, latest_bin, proxies=proxies)
    else:
        print("Binary is present: %s" % latest_bin)

simply by:

Code: Select all

    print("Downloading: %s" % latest_bin)
    wget(download_url, latest_bin, proxies=proxies)

And it works correctly.
No connection, but I propose adding the argument

--no-windows-containers

In the settings of install_exe_if_needed, this seems very important to me (see https://docs.docker.com/desktop/setup/i ... containers]

[sfonteneau]

Hello

, the problem is that it doesn't work on Luti because it apparently doesn't work on Windows 11:

https://luti.tranquil.it/history/tis-docker-desktop

Command '"Docker Desktop Installer.exe" install --quiet' returned non-zero exit status 4294967291.

Apparently, this is a known issue: https://github.com/microsoft/winget-pkgs/issues/93495

We need to look into why here

[yoann.montouchet]

Ah, okay, it works. For me, the update package with my fix worked on version 4.42; I pushed it to our network. So far, the installation is going smoothly, and we have almost exclusively Windows 11.
I don't think it can work with the current code, though, right?

[sfonteneau]

I think it can't work with the current code anyway, right?

Yes, I confirm regarding the update package.

I'm not really sure about the installation. Here at least on Windows 11 24h2 English, it doesn't work.

I'll try again and see

[yoann.montouchet]

The large-scale deployment failed miserably, indeed...

Code: Select all

(output))\nwaptutils.CalledProcessErrorOutput: Command \'"Docker Desktop Installer.exe" install --quiet -–no-windows-containers\' returned non-zero exit status 4294967291.\nOutput:\n']]

We rolled back to version 4.40.0 as a result.
I don't understand why it happened on my machine, but in any case I confirm the problem!

[yoann.montouchet]

I just saw that Docker Desktop 4.43.2 successfully passed the build via luti, including for Windows 11, which was failing before.
It seems that the applied fixes (I noticed the setup.py file had changed quite a bit), or perhaps something on the Docker side, resolved the issue.
I'm starting a small-scale deployment of this version here; I'll let you know how it goes as soon as possible.

For now, it's working on my machine.
I think we'll be able to mark this issue as "resolved" soon!

[dcardon]

Hi Yoann,

did the deployment go smoothly? I'd like to mark this post as resolved.

Regards,

Denis

[yoann.montouchet]

Hello Denis,
For the moment I've limited the deployment to 2 workstations, we haven't had any problems, but I'm not going to expand further on a Friday, that would be a bit too risky.
I'll look into expanding at the beginning of the week, I'm quite confident!

[yoann.montouchet]

Given our current workload, we'll continue with a gradual rollout. We were able to install versions 4.43.2 and 4.44.0 without any issues on some of our machines using the packages that were in testing mode.
I think we can mark this as resolved now...
Thanks!