Problem with package tis-kicad10

[Olivier Schmitt]

Good morning,

There is a problem in the KiCad 10 package

You uninstall all previous versions of KiCad.
KiCad is a software program that operates globally through major version updates
Therefore, the following should be replaced:

Code: Select all

def install():

    # Declaring local variables
    bin_name = glob.glob("kicad-*-x86_64.exe")[0]
    # Installing the software

    # Uninstalling the software
    for to_uninstall in installed_softwares("KiCad "):
        print("Removing: %s (%s)" % (to_uninstall["name"], to_uninstall["version"]))
        killalltasks(ensure_list(control.impacted_process))
        run(uninstall_cmd(to_uninstall["key"]))
        wait_uninstallkey_absent(to_uninstall["key"])

    app_uninstallkey = 'KiCad ' + str(Version(control.get_software_version(),2))
   
    install_exe_if_needed(bin_name,
        silentflags='/allusers /S',
        key= app_uninstallkey,
        min_version=control.get_software_version(),
        timeout=1200
    )

    quiet_uninstall_string = installed_softwares(uninstallkey=app_uninstallkey)[0]["uninstall_string"] + " /S"
    register_uninstall(app_uninstallkey, quiet_uninstall_string=quiet_uninstall_string)
    
    #run([makepath(programfiles, r"C:\Program Files\KiCad\9.0\uninstall.exe"), "/allusers", "/S"])

As with version 9, this one needs testing:

Code: Select all

def install():
    # Declaring local variables
    bin_name = glob.glob("kicad-*-x86_64.exe")[0]
    # Installing the software

    app_uninstallkey = 'KiCad ' + str(Version(control.get_software_version(),2))
   
    install_exe_if_needed(bin_name,
        silentflags='/allusers /S',
        key= app_uninstallkey,
        min_version=control.get_software_version(),
        timeout=1200
    )

    quiet_uninstall_string = installed_softwares(uninstallkey=app_uninstallkey)[0]["uninstall_string"] + " /S"
        
    register_uninstall(app_uninstallkey, quiet_uninstall_string=quiet_uninstall_string)

[italbot]

Hello,

From what I see in the latest version of the KiCad9 package, there's also an uninstallation of all previous versions before installation. I'll look into what can be done for these two packages. The idea is to keep the previous major version, is that correct?

Sincerely,

Ingrid

[Olivier Schmitt]

Hello,

Yes, the idea is to be able to install multiple major versions.
With KiCad 9, it normally searched for previous minor versions to uninstall them.
With the other two versions, 7 and 8, a single installation was sufficient without uninstalling the previous minor versions.

The idea is that for version 9, as with version 10, for example, only the previous 10.xx versions are uninstalled for version 10, and for version 9, only the 9.xx versions, and so on.

[Olivier Schmitt]

Hello, any news?
Could you remove:

Code: Select all

    # Uninstalling the software
    for to_uninstall in installed_softwares("KiCad "):
        print("Removing: %s (%s)" % (to_uninstall["name"], to_uninstall["version"]))
        killalltasks(ensure_list(control.impacted_process))
        run(uninstall_cmd(to_uninstall["key"]))
        wait_uninstallkey_absent(to_uninstall["key"])

[italbot]

Good morning,

Sorry, the package had an error after the changes; the latest build was released 6 days ago, so it's now available on the store as you can see at the link below:
https://wapt.tranquil.it/store/fr/tis-kicad10

I replaced this section of code with:

Code: Select all

 app_uninstallkey = 'KiCad ' + str(Version(control.get_software_version(),2))

    # Uninstalling the software
    for to_uninstall in installed_softwares(app_uninstallkey):
        print("Removing: %s (%s)" % (to_uninstall["name"], to_uninstall["version"]))
        killalltasks(ensure_list(control.impacted_process))
        run(uninstall_cmd(to_uninstall["key"]))
        wait_uninstallkey_absent(to_uninstall["key"])

To uninstall only the previous version 10.
I'll let you test the package and give me feedback to let me know if the behavior is as expected.

Sincerely,

Ingrid