[SOLVED] Error on the tis-jamovi package

[esberard]

Good morning,

There is an error in the placement of the "key" value in your setup which causes the package to fail if the version is present instead of checking the value in the registry.

Your code:

Code: Select all

def install():

    install_exe_if_needed(
        glob.glob("*jamovi*.exe")[0],
        silentflags="/S",
        min_version=control.get_software_version(),
    )
    key="jamovi %s" % control.get_software_version()
    wait_uninstallkey_present(key)

The corrected code:

Code: Select all

def install():

    install_exe_if_needed(
        glob.glob("*jamovi*.exe")[0],
        silentflags="/S",
        min_version=control.get_software_version(),
        key="jamovi %s" % control.get_software_version()
    )

THANKS

Remy

[italbot]

Hello,

If I remember correctly, we did this intentionally because there was a problem with the registry key; we couldn't use it for uninstallation, but we still wanted to verify that the software was installed correctly. Does the error appear when the same version is already present? I'll see what I can do.

Best regards,

Ingrid

[esberard]

Yes, the problem occurs if the same version is present.

Alternatively, it is possible to go through the value uninstallkey.remove('CLEMONSOFTWARE')

Example using an older version of Office:

Code: Select all

install_exe_if_needed("setup.exe",silentflags="/adminfile unistra.MSP",key='Office16.PROPLUS',min_version="16.0.4266.1001", timeout=3600)
filecopyto('OffScrub16.vbs',r'c:\windows')
uninstallkey.remove('Office16.PROPLUS')

[italbot]

I think we can modify the code in the following way with the need_install() function so that there is only an installation if Jamovi of a lower version is installed, if the version is equal to or higher there is no attempt to install.

Code: Select all

def install():

    bin_name =  glob.glob("*jamovi*.exe")[0]
    key="jamovi %s" % control.get_software_version()

    if need_install(key = key, min_version = control.get_software_version()) : 
        run(bin_name + "/S")
        wait_uninstallkey_present(key)
        
    else : 
        print("Jamovi is already installed")

Can you test it and tell me if it works correctly on your end?
If everything is okay, I will modify the package.

Sincerely,

Ingrid

[italbot]

I just saw your previous message; indeed, it also works with uninstallkey.remove(). I've made the change; you can find the pre-production package below:
https://wapt.tranquil.it/store/fr/tis-jamovi

Sincerely,

Ingrid

[esberard]

Thanks for the update