[SOLVED] tis-vmwaretools

[jsdmc]

Hello,

there's a version recognition problem after installation in tis-vmwaretools.

The package installs the application, but when verifying the installation key in the registry, the package expects vmwaretools-version-build, while the key returns vmwaretools-version.

Therefore, the package remains in error despite the application installing correctly.

[dcardon]

Hi Julien,

thanks for the update.

Just so you know, the WAPT packages for Windows x64 are being tested on a Proxmox farm, and the VMware Tools installation setup.exe won't launch if the VM's BIOS isn't a VMware BIOS, so the installation test must have been bypassed. Normally, the LUTI farm tests the uninstallation keys, but in this case, it couldn't be tested and it was missed.

We'll look into fixing it quickly.

Best regards,

Denis

[kcherel]

Hello Julien,

Indeed, there is an inconsistency between the version present on the name of the recovered binary and the one corresponding to the version referenced on the binary.

The problem has just been resolved.
Here is the fix applied to the setup.py file:

Code: Select all

# -*- coding: utf-8 -*-
from setuphelpers import *

def is_vmware_host():
    wmi = wmi_info(keys=['Win32_ComputerSystem'])
    computer_system = wmi['Win32_ComputerSystem']

    if isinstance(computer_system, dict):
        if 'VMware, Inc.' in computer_system['Manufacturer']:
            return True

    if isinstance(computer_system, list):
        for v in computer_system:
            if 'VMware, Inc.' in v['Manufacturer']:
                return True
            
    return False

def install():
    bin_name = glob.glob("VMware-tools-*.exe")[0]
    print(f"Installing: {bin_name}")

    if not is_vmware_host():
        error("The current computer is not VMware virtual machine !")

    install_exe_if_needed(
        bin_name,
        silentflags='/S /v /qn REBOOT=R',
        name="VMware Tools",
        min_version=str(Version(control.get_software_version(),3)),
        get_version=get_installed_version
    )
def get_installed_version(key):
    return str(Version(key["version"],3))

Good day,
Sincerely,
Kevin.