[SOLVED] http_proxy: get() takes exactly 3 arguments (4 given)

[Floflobel]

Good morning,

We noticed today that all of our workstations behind a proxy were no longer communicating with the WAPT server.
After many hours of research, it seems we have understood the problem.

The WAPT service was down on the workstations with this error:


We looked at the code in common.py and found a difference between two versions:
1.8.2

Code: Select all

            if config.has_option(section,'use_http_proxy_for_server') and config.getboolean(section,'use_http_proxy_for_server'):
                if config.has_option(section,'http_proxy'):
                    self.proxies = {'http':config.get(section,'http_proxy',''),'https':config.get(section,'http_proxy','')}
                else:
                    self.proxies = {'http':'','https':''}
            else:
                self.proxies = {'http':'','https':''}

1.7.4

Code: Select all

      self.use_kerberos =  config.getboolean(section,'use_kerberos')
            if config.has_option(section,'use_http_proxy_for_server') and config.getboolean(section,'use_http_proxy_for_server'):
                if config.has_option(section,'http_proxy'):
                    self.proxies = {'http':config.get(section,'http_proxy'),'https':config.get(section,'http_proxy')}
                else:
                    self.proxies = None

I noticed that we're calling the `config.get` function with an empty argument. I don't know if that's the cause of the problem...
After downgrading the agent version on the machine, we were able to regain control of it.

Is this a known issue on your end?
Thanks in advance.

[dcardon]

Which agent version, which server version? (see forum rules)

[Floflobel]

Version with the problem:
WAPT Server version: 1.8.2
WAPT Agent version: 1.8.2.7334

Example version without the problem:
WAPT Server version: 1.8.2
WAPT Agent version: 1.5.1.26

[htouvet]

Good morning,
Yes, that is indeed a mistake.
The third parameter '' must be removed from the get() call
Thank you for your feedback.

ps. In version 2, the call works correctly (same as 1.7)

Code: Select all

            if config.has_option(section, 'use_http_proxy_for_server') and config.getboolean(section, 'use_http_proxy_for_server'):
                if config.has_option(section, 'http_proxy'):
                    self.proxies = {'http': config.get(section, 'http_proxy'), 'https': config.get(section, 'http_proxy')}
                else:
                    self.proxies = None
            else:
                self.proxies = {'http': None, 'https': None}

[dcardon]

Version with the problem:
WAPT Server version: 1.8.2
WAPT Agent version: 1.8.2.7334

Example version without the problem:
WAPT Server version: 1.8.2
WAPT Agent version: 1.5.1.26

The fix has been pushed to the 1.8.2 branch. It will be available in the next 1.8.2 release (no date announced yet). Alternatively, you can upgrade to 2.0; the bug is not present there.

Sincerely,

Denis

[Floflobel]

Thank you for your feedback and quick response regarding the fix in version 1.8.2.

Since my workstations are no longer reachable, is a manual update or one using another tool required? Is the fix not only server-side but also agent-side?

[dcardon]

If you have an Active Directory domain, the Group Policy Object (GPO) will be able to update the workstations and you will regain the connection

[htouvet]

The bug appears to affect the connection to the server, but not the downloading of packages from the repository.
If the machines apply the packages while shut down, they will install the new package, waptupgrade version 1.8.2.7367.

[Floflobel]

Unfortunately, there's no domain on these machines.

I'll run my tests when the new version is available.

Thanks again for your feedback and quick response.