[SOLVED] setuphelpers.killalltask function (needs fixing?)

[louisinger]

Good morning,

I've just noticed a slight problem with the killalltask function. This occurs, for example, when install_msi_if_needed() is called like this:

Code: Select all

install_msi_if_needed(msi = msi, remove_old_version = True, killbefore = None)

If :
1. killbefore = None (default value)
2. remove_old_version = True
SO :
As :

Code: Select all

if remove_old_version :
        killalltasks(killbefore)
        remove_previous_version(key,min_version)

so killalltask will be called with the value None and killalltask(None) = AttributeError: 'NoneType' object has no attribute 'lower'

I'm not sure about this and maybe there's an explanation, but in doubt I preferred to post a message.

[htouvet]

Yes, we need to add a test...
Thank you!